Code Review -- The OpenBeOS Storage Kit Team

Code Review:
This table is used to keep track of which files have been reviewed when and by whom. Don't forget that most header/source pairs also have associated testing code in /storage_kit/test/ that also needs to be looked over.

Things To Look For:
(include but are not limited to)
+ Bugs
+ Questionable design decisions
+ Confusing code that might benefit from better comments
+ Things that could be optimized
+ Unnecessary #includes
+ Unnecessary friend declarations
+ Unnecessary forward declarations
+ The occasional correct implementation ;-)

Comments should be sent to the author. Let me or the mailing list know when you've finished reviewing a set of files.

Filename(s):

kernel_interface.h

kernel_interface.POSIX.cpp

storage_support.{h,cpp}

Directory.{h,cpp}
DirectoryTest.{h,cpp}

Entry.{h,cpp}
EntryTest.{h,cpp}

EntryList.{h,cpp}
EntryListTest.{h,cpp}

File.{h,cpp}
FileTest.{h,cpp}

Node.{h,cpp}
NodeTest.{h,cpp}

Path.{h,cpp}
PathTest.{h,cpp}

Statable.{h,cpp}
StatableTest.{h,cpp}

SymLink.{h,cpp}
SymLinkTest.{h,cpp}

AppFileInfo.{h,cpp}
AppFileInfoTest.{h,cpp}

Mime.{h,cpp}
MimeTest.{h,cpp}

MimeType.{h,cpp}
MimeTypeTest.{h,cpp}

NodeInfo.{h,cpp}
NodeInfoTest.{h,cpp}

Query.{h,cpp}
QueryTest.{h,cpp}

Resources.{h,cpp}
ResourcesTest.{h,cpp}

ResourceStrings.{h,cpp}
ResourceStringsTest.{h,cpp}

Volume.{h,cpp}
VolumeTest.{h,cpp}

VolumeRoster.{h,cpp}
VolumeRosterTest.{h,cpp}

Alias.{h,cpp}
AliasTest.{h,cpp}

FindDirectory.{h,cpp}
FindDirectoryTest.{h,cpp}

NodeMonitor.{h,cpp}
NodeMonitorTest.{h,cpp}

Pre-Alpha:

Ingo, Tyler

Alpha:

Beta:

Stable:

Mature:

last updated June 8, 2002